On Thu, Nov 6, 2014 at 8:00 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Fri, Oct 24, 2014 at 3:41 AM, Fabrízio de Royes Mello
> <fabriziomello@gmail.com> wrote:
>> On Wed, Oct 22, 2014 at 9:21 PM, Alvaro Herrera <alvherre@2ndquadrant.com>
>> wrote:
>>>
>>> Sawada Masahiko wrote:
>>>
>>> > Thank you for reviewing.
>>> > I agree 2) - 5).
>>> > Attached patch is latest version patch I modified above.
>>> > Also, I noticed I had forgotten to add the patch regarding document of
>>> > reindexdb.
>>>
>>> Please don't use pg_catalog in the regression test. That way we will
>>> need to update the expected file whenever a new catalog is added, which
>>> seems pointless. Maybe create a schema with a couple of tables
>>> specifically for this, instead.
>>>
>>
>> Attached new regression test.
>
> Hunk #1 FAILED at 1.
> 1 out of 2 hunks FAILED -- saving rejects to file
> src/bin/scripts/t/090_reindexdb.pl.rej
>
> I tried to apply the 001 patch after applying the 000, but it was not
> applied cleanly.
>
> At least to me, it's more intuitive to use "SCHEMA" instead of "ALL IN SCHEMA"
> here because we already use "DATABASE" instead of "ALL IN DATABASE".
>
Thank you for reporting.
Um, that's one way of looking at it
I think It's not quite new syntax, and we have not used "ALL IN"
clause in REINDEX command by now.
If we add SQL command to reindex table of all in table space as newly syntax,
we might be able to name it "REINDEX TABLE ALL IN TABLESPACE".
Anyway, I created patch of "REINDEX SCHEMA" version, and attached.
Also inapplicable problem has been solved.
Regards,
-------
Sawada Masahiko
