Re: [BUG] FailedAssertion in SnapBuildPurgeOlderTxn - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: [BUG] FailedAssertion in SnapBuildPurgeOlderTxn
Date
Msg-id CAD21AoD5k=PhEWjnEtwGrCrF0YuZJna5AGDRZHbnrAvhF=zOTA@mail.gmail.com
Whole thread Raw
In response to Re: [BUG] FailedAssertion in SnapBuildPurgeOlderTxn  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [BUG] FailedAssertion in SnapBuildPurgeOlderTxn
Re: [BUG] FailedAssertion in SnapBuildPurgeOlderTxn
List pgsql-hackers
On Wed, Nov 23, 2022 at 12:00 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Nov 22, 2022 at 10:33 PM Maxim Orlov <orlovmg@gmail.com> wrote:
> >>
> >>
> >> Regarding the tests, the patch includes a new scenario to
> >> reproduce this issue. However, since the issue can be reproduced also
> >> by the existing scenario (with low probability, though), I'm not sure
> >> it's worth adding the new scenario.
> >
> > AFAICS, the test added doesn't 100% reproduce this issue, so, maybe, it does not worth it. But, I do not have a
strongopinion here.
 
> > Let's add tests in a separate commit and let the actual committer to decide what to do, should we?
> >
>
> +1 to not have a test for this as the scenario can already be tested
> by the existing set of tests.

Agreed not to have a test case for this.

I've attached an updated patch. I've confirmed this patch works for
all supported branches.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: doc: Fix description of how the default user name is chosen
Next
From: mahendrakar s
Date:
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER