Re: [HACKERS] Fix a typo in snapmgr.c - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: [HACKERS] Fix a typo in snapmgr.c
Date
Msg-id CAD21AoCT+73jJv-LJNMEd0ayvknQ2Q0ZWfgtHRFSN5jzExq6wA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Fix a typo in snapmgr.c  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Thu, Jun 8, 2017 at 2:17 AM, Andres Freund <andres@anarazel.de> wrote:
> On 2017-05-08 09:12:13 -0400, Tom Lane wrote:
>> Simon Riggs <simon@2ndquadrant.com> writes:
>> > So rearranged code a little to keep it lean.
>>
>> Didn't you break it with that?  As it now stands, the memcpy will
>> copy the nonzero value.
>
> I've not seen a fix and/or alleviating comment about this so far.  Did I
> miss something?
>

I think we don't have the fix for the comment from Tom so far, too.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] PostgreSQL 10 changes in exclusion constraints - did something change? CASE WHEN behavior oddity
Next
From: Tom Lane
Date:
Subject: [HACKERS] Does pg_upgrade really support "make installcheck"?