On Thu, Sep 5, 2019 at 10:41 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Sep 04, 2019 at 04:50:45PM -0400, Alvaro Herrera wrote:
> > According to CFbot, the Windows build fails with this patch. Please
> > fix.
>
> To save a couple of clicks:
> "C:\projects\postgresql\pageinspect.vcxproj" (default target) (56) ->
> (Link target) ->
> heapfuncs.obj : error LNK2001: unresolved external symbol
> pg_popcount32 [C:\projects\postgresql\pageinspect.vcxproj]
> .\Release\pageinspect\pageinspect.dll : fatal error LNK1120: 1
> unresolved externals [C:\projects\postgresql\pageinspect.vcxproj]
>
> I think that it would be more simple to just use pg_popcount().
> That's what other contrib modules do (for example ltree or intarray).
Thanks. I hope the attached new patch fixes this issue.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
