Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
Date
Msg-id 20190905014131.GD14853@paquier.xyz
Whole thread Raw
In response to Re: [HACKERS] [PATCH] pageinspect function to decode infomasks  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
List pgsql-hackers
Tree view 
On Wed, Sep 04, 2019 at 04:50:45PM -0400, Alvaro Herrera wrote:
> According to CFbot, the Windows build fails with this patch.  Please
> fix.

To save a couple of clicks:
"C:\projects\postgresql\pageinspect.vcxproj" (default target) (56) ->
(Link target) ->
  heapfuncs.obj : error LNK2001: unresolved external symbol
  pg_popcount32 [C:\projects\postgresql\pageinspect.vcxproj]
    .\Release\pageinspect\pageinspect.dll : fatal error LNK1120: 1
    unresolved externals [C:\projects\postgresql\pageinspect.vcxproj]

I think that it would be more simple to just use pg_popcount().
That's what other contrib modules do (for example ltree or intarray).
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pg_promote() can cause busy loop
Next
From: Fujii Masao
Date:
Subject: Re: pg_promote() can cause busy loop