On Fri, Sep 18, 2015 at 6:13 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Fri, Sep 4, 2015 at 2:55 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> On Fri, Sep 4, 2015 at 10:35 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>>> On Fri, Sep 4, 2015 at 2:23 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>>> On Thu, Aug 27, 2015 at 1:54 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>>>> On Thu, Aug 20, 2015 at 11:46 PM, Alvaro Herrera
>>>>> <alvherre@2ndquadrant.com> wrote:
>>>>>> Jim Nasby wrote:
>>>>>>
>>>>>>> I think things like pageinspect are very different; I really can't see any
>>>>>>> use for those beyond debugging (and debugging by an expert at that).
>>>>>>
>>>>>> I don't think that necessarily means it must continue to be in contrib.
>>>>>> Quite the contrary, I think it is a tool critical enough that it should
>>>>>> not be relegated to be a second-class citizen as it is now (let's face
>>>>>> it, being in contrib *is* second-class citizenship).
>>>>>>
>>>>>
>>>>> Attached patch is latest patch.
>>>>
>>>> The previous patch lacks some files for regression test.
>>>> Attached fixed v12 patch.
>>>
>>> The patch could be applied cleanly. "make check" could pass successfully.
>>> But "make check-world -j 2" failed.
>>>
>>
>> Thank you for looking at this patch.
>> Could you tell me what test you got failed?
>> make check-world -j 2 or more is done successfully in my environment.
>
> I tried to do the test again, but initdb failed with the following error.
>
> creating template1 database in data/base/1 ... FATAL: invalid
> input syntax for type oid: "f"
>
> This error didn't happen when I tested before. So the commit which was
> applied recently might interfere with the patch.
>
Thank you for testing!
Attached fixed version patch.
Regards,
--
Masahiko Sawada
