Re: patch for parallel pg_dump - Mailing list pgsql-hackers

From Joachim Wieland
Subject Re: patch for parallel pg_dump
Date
Msg-id CACw0+10jHnkSxJZmpM2AP=_KqsCy2n1h7TzsMk0z8YMmViZw4A@mail.gmail.com
Whole thread Raw
In response to Re: patch for parallel pg_dump  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: patch for parallel pg_dump  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On Wed, Mar 28, 2012 at 5:19 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
> First hurdle: It doesn't build under Windows/mingw-w64:
>
>   parallel.c:40:12: error: static declaration of 'pgpipe' follows
>   non-static declaration

Strange, I'm not seeing this but I'm building with VC2005. What
happens is that you're pulling in the pgpipe.h header. I have moved
these functions as static functions into pg_dump since you voted for
removing them from the other location (because as it turned out,
nobody else is currently using them).

Joachim


pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)
Next
From: Noah Misch
Date:
Subject: Re: ECPG FETCH readahead