Re: [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot() - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()
Date
Msg-id CACjxUsNW5Eo35B2PeavbWFgK7A9hC=C-jshOZ2g1OW3xD8+g+w@mail.gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()  (Kevin Grittner <kgrittn@gmail.com>)
Responses Re: [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()  (Kevin Grittner <kgrittn@gmail.com>)
List pgsql-hackers
On Thu, Apr 21, 2016 at 9:58 AM, Kevin Grittner <kgrittn@gmail.com> wrote:
> On Thu, Apr 21, 2016 at 8:47 AM, Kevin Grittner <kgrittn@postgresql.org> wrote:
>> Inline initial comparisons in TestForOldSnapshot()
>
> This seems to have broken Windows builds.  Is there something
> special that needs to be done if a function referenced from a
> contrib module changes to an inline function?

I've attempted to fix this by adding an include to blscan.c so that
it can find old_snapshot_threshold.  The fact that this was only
failing in a contrib module on Windows builds has me suspicious
that there is some other way this would be better fixed, but I have
no clue what that would be.  We'll see whether this brings things
green again.

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: Typos/Questions in bloom documentation
Next
From: Robert Haas
Date:
Subject: Re: Parser extensions (maybe for 10?)