Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher - Mailing list pgsql-hackers

From Önder Kalacı
Subject Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Date
Msg-id CACawEhXGnk6v7UOHrxuJjjybHvvq33Zv666ouy4UzjPfJM6tBw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Hi,

Amit Kapila <amit.kapila16@gmail.com>, 8 Mar 2023 Çar, 14:42 tarihinde şunu yazdı:
On Wed, Mar 8, 2023 at 4:51 PM Önder Kalacı <onderkalaci@gmail.com> wrote:
>
>
>>
>> I just share this case and then we
>> can discuss should we pick the index which only contain the extra columns on the
>> subscriber.
>>
>
> I think its performance implications come down to the discussion on [1]. Overall, I prefer
> avoiding adding any additional complexity in the code for some edge cases. The code
> can handle this sub-optimal user pattern, with a sub-optimal performance.
>

It is fine to leave this and Hou-San's case if they make the patch
complex. However, it may be better to give it a try and see if this or
other regression/optimization can be avoided without adding much
complexity to the patch. You can prepare a top-up patch and then we
can discuss it.



Alright, I did some basic prototypes for the problems mentioned, just to show
that these problems can be solved without too much hassle. But, the patchees
are not complete, some tests fail, no comments / tests exist, some values should be
cached etc.  Mostly sharing as a heads up and sharing the progress given I have not
responded to this specific mail. I'll update these when I have some extra time after
replying to the 0001 patch. 

 Thanks,
Onder
Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Next
From: Önder Kalacı
Date:
Subject: Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher