Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Date
Msg-id CAA4eK1+oM_v-b_WDHZmqCyVHU2oD4j3vF9YcH9xVHj=zAfy4og@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher  (Önder Kalacı <onderkalaci@gmail.com>)
Responses Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher  (Önder Kalacı <onderkalaci@gmail.com>)
List pgsql-hackers
On Wed, Mar 8, 2023 at 4:51 PM Önder Kalacı <onderkalaci@gmail.com> wrote:
>
>
>>
>> I just share this case and then we
>> can discuss should we pick the index which only contain the extra columns on the
>> subscriber.
>>
>
> I think its performance implications come down to the discussion on [1]. Overall, I prefer
> avoiding adding any additional complexity in the code for some edge cases. The code
> can handle this sub-optimal user pattern, with a sub-optimal performance.
>

It is fine to leave this and Hou-San's case if they make the patch
complex. However, it may be better to give it a try and see if this or
other regression/optimization can be avoided without adding much
complexity to the patch. You can prepare a top-up patch and then we
can discuss it.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Önder Kalacı
Date:
Subject: Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Next
From: "Drouvot, Bertrand"
Date:
Subject: Re: Track IO times in pg_stat_io