Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL - Mailing list pgsql-hackers

From Önder Kalacı
Subject Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
Date
Msg-id CACawEhWkFwQ5Zuu9NOQiJtjnQY+At8JuhKQ6cJ7wEvWv+Vb=+g@mail.gmail.com
Whole thread Raw
In response to Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL  (Amit Kapila <amit.kapila16@gmail.com>)
Responses RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL  ("shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>)
List pgsql-hackers
Hi Amit, all
 
You can first submit the fix for dropped columns with patches till
v10. Once that is committed, then you can send the patches for
generated columns.


Alright, attaching 2 patches for dropped columns, the names of the files shows which 
versions the patch can be applied to:
v2-0001-Ignore-dropped-columns-HEAD-REL_15-REL_14-REL_13.patch
v2-0001-Ignore-dropped-columns-REL_12-REL_11.patch 

And, then on top of that, you can apply the patch for generated columns on all applicable
versions (HEAD, 15, 14, 13 and 12). It applies cleanly.  The name of the file
is: v2-0001-Ignore-generated-columns.patch


But unfortunately I couldn't test the patch with PG 12 and below. I'm getting some
unrelated compile errors and Postgrees CI is not available on these versions . I'll try
to fix that, but I thought it would still be good to share the patches as you might
already have the environment to run the tests. 


Don't worry about v10 --- that's out of support and shouldn't
get patched for this.

Given this information, I skipped the v10 patch.

Thanks,
Onder KALACI 
Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Add pg_walinspect function with block info columns
Next
From: Masahiko Sawada
Date:
Subject: Re: [PoC] Improve dead tuple storage for lazy vacuum