Re: doc: clarify the limitation for logical replication when REPILICA IDENTITY is FULL - Mailing list pgsql-hackers

From Önder Kalacı
Subject Re: doc: clarify the limitation for logical replication when REPILICA IDENTITY is FULL
Date
Msg-id CACawEhVQSpzHubFSKM=OVW_gtUDBTAc8h5=uV+MEVhaLgC6bbg@mail.gmail.com
Whole thread Raw
In response to Re: doc: clarify the limitation for logical replication when REPILICA IDENTITY is FULL  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: doc: clarify the limitation for logical replication when REPILICA IDENTITY is FULL
Re: doc: clarify the limitation for logical replication when REPILICA IDENTITY is FULL
List pgsql-hackers
Hi,

>
> The last line seems repetitive to me. So, I have removed it. Apart
> from that patch looks good to me. Sergie, Peter, and others, any
> thoughts?

The v5 patch LGTM.

 
Overall looks good to me as well. Please consider the following as an optional improvement.

My only minor concern here is the use of the term "default operator class". It is accurate to use it. However, as far as I know, not many users can follow that easily. I think the "pkey/repl full" suggestion gives some tip, but I wonder if we add something like the following to the text such that users can understand more:

 do not have a default operator class for B-tree or Hash.
+ If  there is no default operator class, usually the type does not have an equality operator.
However,  this limitation ..

Thanks,
Onder

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [PoC] pg_upgrade: allow to upgrade publisher node
Next
From: Erik Rijkers
Date:
Subject: Re: remaining sql/json patches