Re: doc: clarify the limitation for logical replication when REPILICA IDENTITY is FULL - Mailing list pgsql-hackers

On Mon, Jul 17, 2023 at 11:51 AM Önder Kalacı <onderkalaci@gmail.com> wrote:
>
>> >
>> > The last line seems repetitive to me. So, I have removed it. Apart
>> > from that patch looks good to me. Sergie, Peter, and others, any
>> > thoughts?
>>
>> The v5 patch LGTM.
>>
>
> Overall looks good to me as well. Please consider the following as an optional improvement.
>
> My only minor concern here is the use of the term "default operator class". It is accurate to use it. However, as far
asI know, not many users can follow that easily. I think the "pkey/repl full" suggestion gives some tip, but I wonder
ifwe add something like the following to the text such that users can understand more: 
>
>>  do not have a default operator class for B-tree or Hash.
>>
>> + If  there is no default operator class, usually the type does not have an equality operator.
>>

This sounds a bit generic to me. If required, we can give an example
so that it is easier to understand. But OTOH, I see that we use
"default operator class" in the docs and error messages, so this
should be probably okay.


--
With Regards,
Amit Kapila.