Re: [patch] libpq one-row-at-a-time API - Mailing list pgsql-hackers

From Marko Kreen
Subject Re: [patch] libpq one-row-at-a-time API
Date
Msg-id CACMqXC+QAJvhAKDCqrjVzVF7gJnyDq1ZsXKM_f1GkjpzGoSjUQ@mail.gmail.com
Whole thread Raw
In response to Re: [patch] libpq one-row-at-a-time API  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [patch] libpq one-row-at-a-time API  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Jul 16, 2012 at 4:11 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Marko Kreen <markokr@gmail.com> writes:
>> Now, looking at the problem with some perspective, the solution
>> is obvious: when in single-row mode, the PQgetResult() must return
>> proper PGresult for that single row.  And everything else follows that.
>
>> Such API is implemented in attached patch:
>
> I'm starting to look at this patch now.  I think we could drop the
> PQgetRowData() API: it complicates matters for little gain that I can
> see.  The argument for it was to avoid the cost of creating a PGresult
> per row, but we're already going to pay the cost of creating a
> PGresult in order to return the PGRES_SINGLE_TUPLE status.

No.  Please look again, it is supposed to be called instead of PGgetResult().

-- 
marko


pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: CompactCheckpointerRequestQueue versus pad bytes
Next
From: Tom Lane
Date:
Subject: Re: [patch] libpq one-row-at-a-time API