Re: [patch] libpq one-row-at-a-time API - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [patch] libpq one-row-at-a-time API
Date
Msg-id 23653.1342445619@sss.pgh.pa.us
Whole thread Raw
In response to Re: [patch] libpq one-row-at-a-time API  (Marko Kreen <markokr@gmail.com>)
Responses Re: [patch] libpq one-row-at-a-time API
List pgsql-hackers
Marko Kreen <markokr@gmail.com> writes:
> On Mon, Jul 16, 2012 at 4:11 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'm starting to look at this patch now.  I think we could drop the
>> PQgetRowData() API: it complicates matters for little gain that I can
>> see.  The argument for it was to avoid the cost of creating a PGresult
>> per row, but we're already going to pay the cost of creating a
>> PGresult in order to return the PGRES_SINGLE_TUPLE status.

> No.  Please look again, it is supposed to be called instead of PGgetResult().

Mm.  I still think we should drop it, because it's still a dangerous API
that's not necessary for the principal benefit of this feature.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Marko Kreen
Date:
Subject: Re: [patch] libpq one-row-at-a-time API
Next
From: Robert Haas
Date:
Subject: Re: CompactCheckpointerRequestQueue versus pad bytes