Postgres Pro
Downloads
Home   >   mailing lists

[pgAdmin4][patch]: String evaluation issue - Mailing list pgadmin-hackers

From Neel Patel
Subject [pgAdmin4][patch]: String evaluation issue
Date
Msg-id CACCA4P3b2MskMggrE=GiL5_MNhGPfaMr1u1u-XvsYHvNOuF+aA@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][patch]: String evaluation issue  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi,

Please find attached patch file containing the fix for the below issue.
This issue is reported by Dave during the debugger code review and we have removed the same issue from other files where we used.

Issue :- 

When we use below string to form the error message then it will not work because Jinja will evaluate the string " + err.errormsg + " before it gets evaluated as JS by the browser.

           alertify.error("{{ _('" + err.errormsg + "') }}");


Do review it and let us know for any comments.

Thanks,
Neel Patel

Attachment

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Adding missing query templates required for the serve
Next
From: Dave Page
Date:
Subject: Re: PATCH: graphical explain