Re: [pgAdmin4][patch]: String evaluation issue - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][patch]: String evaluation issue
Date
Msg-id CA+OCxoyWHjtFiDU6GbexDtCDqyfgMndE29rfVesmdiheWBTvkg@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][patch]: String evaluation issue  (Neel Patel <neel.patel@enterprisedb.com>)
List pgadmin-hackers
Thanks, applied.

On Monday, April 18, 2016, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi,

Please find attached patch file containing the fix for the below issue.
This issue is reported by Dave during the debugger code review and we have removed the same issue from other files where we used.

Issue :- 

When we use below string to form the error message then it will not work because Jinja will evaluate the string " + err.errormsg + " before it gets evaluated as JS by the browser.

           alertify.error("{{ _('" + err.errormsg + "') }}");


Do review it and let us know for any comments.

Thanks,
Neel Patel



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Don't try to use the template engine's gettext on Jav
Next
From: Murtuza Zabuawala
Date:
Subject: [PATCH] Tables node (pgAdmin4)