At Thu, 19 Dec 2019 11:15:26 +0900, Michael Paquier <michael@paquier.xyz> wrote in > Hi all, > > As discussed here, there is in the tree a couple of things related to > past versions of Windows: > https://www.postgresql.org/message-id/201912180219SUSv254.GE1836@paquier.xyz > > So I have been looking at that more closely, and found more: > - MIN_WINNT can be removed from win32.h thanks to d9dd406 which has > added a requirement on C99 with Windows 7 as minimum platform > supported. (The issue mentioned previously.) > - pipe_read_line(), used when finding another binary for a given > installation via find_other_exec() has some special handling related > to Windows 2000 and older versions. > - When trying to load getaddrinfo(), we try to load it from > wship6.ddl, which was something needed in Windows 2000, but newer > Windows versions include it in ws2_32.dll. > - A portion of the docs still refer to Windows 98. > > Thoughts?
I think MIN_WINNT is definitely emovable.
This is probably not an issue for the supported MSVC and their SDK, but current MinGW defaults to Windows 2003 [1]. So I would suggest a logic like: