Re: Clean up some old cruft related to Windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Clean up some old cruft related to Windows
Date
Msg-id 20200218065418.GK4176@paquier.xyz
Whole thread Raw
In response to Re: Clean up some old cruft related to Windows  (Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>)
Responses Re: Clean up some old cruft related to Windows
List pgsql-hackers
On Thu, Dec 19, 2019 at 08:09:45PM +0100, Juan José Santamaría Flecha wrote:
> This is probably not an issue for the supported MSVC and their SDK, but
> current MinGW defaults to Windows 2003 [1]. So I would suggest a logic like:
>
> #define WINNTVER(ver) ((ver) >> 16)
> #define NTDDI_VERSION 0x06000100
> #define _WIN32_WINNT WINNTVER(NTDDI_VERSION)
>
> [1]
> https://github.com/mirror/mingw-w64/blob/master/mingw-w64-headers/include/sdkddkver.h

You're right, thanks for the pointer.  This is this part of the
header:
#define NTDDI_VERSION NTDDI_WS03

Thinking more about that, the changes in win32.h are giving me cold
feet.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: reindex concurrently and two toast indexes
Next
From: Amit Langote
Date:
Subject: Re: pg_stat_progress_basebackup - progress reporting forpg_basebackup, in the server side