Re: WIN32 pg_import_system_collations - Mailing list pgsql-hackers

From Juan José Santamaría Flecha
Subject Re: WIN32 pg_import_system_collations
Date
Msg-id CAC+AXB2Mvdn=2d0Vfgz6_SGmD=yTUEqdKRJ01BVfDAnZhW+CuA@mail.gmail.com
Whole thread Raw
In response to Re: WIN32 pg_import_system_collations  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: WIN32 pg_import_system_collations  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers

On Mon, Dec 13, 2021 at 9:54 PM Thomas Munro <thomas.munro@gmail.com> wrote:

I haven't tested yet but +1 for the feature.  I guess the API didn't
exist at the time collation support was added.

Good to hear.
 
This conversion makes sense, to keep the user experience the same
across platforms.   Nitpick on the comment: why ANSI?  I think we can
call "en_NZ" a POSIX locale identifier[1], and I think we can call
"en-NZ" a BCP 47 language tag.

POSIX also works for me.
 
When would the full set of locales not be installed on a Windows
system, and why does this need Visual Studio?  Wondering if this test
will work with some of the frankenstein/cross toolchains tool chains
(not objecting if it doesn't and could be skipped, just trying to
understand the comment).

What I meant to say is that to run the test, you need a database that has successfully run pg_import_system_collations. This would be also possible in Mingw for _WIN32_WINNT> = 0x0600, but the current value in src\include\port\win32.h is _WIN32_WINNT = 0x0501 when compiling with Mingw.
 
Regards, 
 Juan José Santamaría Flecha

pgsql-hackers by date:

Previous
From: "Bossart, Nathan"
Date:
Subject: Re: O(n) tasks cause lengthy startups and checkpoints
Next
From: "Bossart, Nathan"
Date:
Subject: Re: O(n) tasks cause lengthy startups and checkpoints