Re: HAVE_WORKING_LINK still needed? - Mailing list pgsql-hackers

From Juan José Santamaría Flecha
Subject Re: HAVE_WORKING_LINK still needed?
Date
Msg-id CAC+AXB1EDXiRPmiVfh+WX79x5vXJDU17k0GkDjfyPgOWO4Y5og@mail.gmail.com
Whole thread Raw
In response to HAVE_WORKING_LINK still needed?  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers

On Fri, Feb 28, 2020 at 2:15 PM Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
I came across the HAVE_WORKING_LINK define in pg_config_manual.h.
AFAICT, hard links are supported on Windows and Cygwin in the OS
versions that we support, and pg_upgrade already contains the required
shim.  It seems to me we could normalize and simplify that, as in the
attached patches.  (Perhaps rename durable_link_or_rename() then.)  I
successfully tested on MSVC, MinGW, and Cygwin.

The link referenced in the comments of win32_pghardlink() [1] is quite old, and is automatically redirected to the current documentation [2]. Maybe this patch should use the new path.


Regards,

Juan José Santamaría Flecha

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [PATCH] Comments related to "Take fewer snapshots" and "Revertpatch for taking fewer snapshots"
Next
From: Tom Lane
Date:
Subject: Re: HAVE_WORKING_LINK still needed?