Re: BUG #15858: could not stat file - over 4GB - Mailing list pgsql-hackers

From Juan José Santamaría Flecha
Subject Re: BUG #15858: could not stat file - over 4GB
Date
Msg-id CAC+AXB0g44SbvSpC86o_1HWh8TAU2pZrMRW6tJT-dkijotx5Qg@mail.gmail.com
Whole thread Raw
In response to Re: BUG #15858: could not stat file - over 4GB  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: BUG #15858: could not stat file - over 4GB  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers

On Fri, Oct 9, 2020 at 10:22 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Emil Iggland <emil@iggland.com> writes:
> I tested the patch at hand, and it performs as expected. Files larger than 4GB can be imported.

Thanks for testing!
 
  Thanks for testing! +1

I'd been expecting one of our Windows-savvy committers to pick this up,
but since nothing has been happening, I took it on myself to push it.
I'll probably regret that :-(

Thanks for taking care of this. I see no problems in the build farm, but please reach me if I missed something. 

I made a few cosmetic changes, mostly reorganizing comments in a way
that made more sense to me.

I was working on a new version, which was pgindent-friendlier and clearer about reporting an error when 'errno' is not informed. Please find attached a patch with those changes.

Regards,

Juan José Santamaría Flecha 
Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: WIP: WAL prefetch (another approach)
Next
From: Amit Kapila
Date:
Subject: Re: Parallel INSERT (INTO ... SELECT ...)