I noticed that the savepointLevel member of TransactionStateData struct is initialized to 0 from TopTransactionStateData, and never incremented or decremented afterwards.
Since this is a file-local struct I think we can simply get rid of all usages of this without any risk. I visited all the commits where this variable was introduced/used/changed and could not find any point in history where it was ever useful. Maybe I missed something, but looks like it is a leftover from someone's forward-thinking.
Patch attached.
Regards,
--
Gurjeet Singh
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
