Re: Removing savepointLevel from TransactionState - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Removing savepointLevel from TransactionState
Date
Msg-id 19847.1317273112@sss.pgh.pa.us
Whole thread Raw
In response to Removing savepointLevel from TransactionState  (Gurjeet Singh <singh.gurjeet@gmail.com>)
Responses Re: Removing savepointLevel from TransactionState
Re: Removing savepointLevel from TransactionState
List pgsql-hackers
Gurjeet Singh <singh.gurjeet@gmail.com> writes:
> I noticed that the savepointLevel member of TransactionStateData struct is
> initialized to 0 from TopTransactionStateData, and never incremented or
> decremented afterwards.

> Since this is a file-local struct I think we can simply get rid of all
> usages of this without any risk.

ISTM you have detected a bug, not just dead code that should be removed.
Surely those tests that throw error on savepointLevel change were
meant to do something important?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: pg_upgrade - add config directory setting
Next
From: Gurjeet Singh
Date:
Subject: Re: Removing savepointLevel from TransactionState