Re: review: Non-recursive processing of AND/OR lists - Mailing list pgsql-hackers

From Gurjeet Singh
Subject Re: review: Non-recursive processing of AND/OR lists
Date
Msg-id CABwTF4V91b4bLBvSk0qX_=TuErd_YsYkxBwQhEt-EeDQdb3kGQ@mail.gmail.com
Whole thread Raw
In response to Re: review: Non-recursive processing of AND/OR lists  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Thanks!

On Mon, Jun 16, 2014 at 3:58 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I wrote:
>> Gurjeet Singh <gurjeet@singh.im> writes:
>>> I tried to eliminate the 'pending' list, but I don't see a way around it.
>>> We need temporary storage somewhere to store the branches encountered on
>>> the right; in recursion case the call stack was serving that purpose.
>
>> I still think we should fix this in the grammar, rather than introducing
>> complicated logic to try to get rid of the recursion later.  For example,
>> as attached.
>
> I went looking for (and found) some additional obsoleted comments, and
> convinced myself that ruleutils.c is okay as-is, and pushed this.
>
>                         regards, tom lane



-- 
Gurjeet Singh http://gurjeet.singh.im/

EDB www.EnterpriseDB.com



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: idle_in_transaction_timeout
Next
From: Gurjeet Singh
Date:
Subject: Re: /proc/self/oom_adj is deprecated in newer Linux kernels