Re: review: Non-recursive processing of AND/OR lists - Mailing list pgsql-hackers

From Tom Lane
Subject Re: review: Non-recursive processing of AND/OR lists
Date
Msg-id 19203.1402948689@sss.pgh.pa.us
Whole thread Raw
In response to Re: review: Non-recursive processing of AND/OR lists  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: review: Non-recursive processing of AND/OR lists  (Gurjeet Singh <gurjeet@singh.im>)
List pgsql-hackers
I wrote:
> Gurjeet Singh <gurjeet@singh.im> writes:
>> I tried to eliminate the 'pending' list, but I don't see a way around it.
>> We need temporary storage somewhere to store the branches encountered on
>> the right; in recursion case the call stack was serving that purpose.

> I still think we should fix this in the grammar, rather than introducing
> complicated logic to try to get rid of the recursion later.  For example,
> as attached.

I went looking for (and found) some additional obsoleted comments, and
convinced myself that ruleutils.c is okay as-is, and pushed this.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: avoiding tuple copying in btree index builds
Next
From: Robert Haas
Date:
Subject: Re: wrapping in extended mode doesn't work well with default pager