It was apparently entirely undocumented that the tablespace size estimates sent by the base backup protocol are in kilobytes. Here is a patch to document that. Also, a related clarification in the pg_basebackup.c source code: It was not clear without analyzing the whole stack that "totalsize" is in kilobytes and "totaldone" is in bytes.
+1, these both look like reasonable changes to me.
