Re: Improve base backup protocol documentation - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Improve base backup protocol documentation
Date
Msg-id 37d3acf9-256d-44b3-6124-e82132739973@2ndquadrant.com
Whole thread Raw
In response to Re: Improve base backup protocol documentation  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On 2019-09-03 09:50, Magnus Hagander wrote:
> On Wed, Aug 28, 2019 at 4:58 PM Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com
> <mailto:peter.eisentraut@2ndquadrant.com>> wrote:
> 
>     It was apparently entirely undocumented that the tablespace size
>     estimates sent by the base backup protocol are in kilobytes.  Here is a
>     patch to document that.  Also, a related clarification in the
>     pg_basebackup.c source code: It was not clear without analyzing the
>     whole stack that "totalsize" is in kilobytes and "totaldone" is in
>     bytes.
> 
> 
> +1, these both look like reasonable changes to me.

committed


-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: BUG #15977: Inconsistent behavior in chained transactions
Next
From: Fabien COELHO
Date:
Subject: Re: BUG #15977: Inconsistent behavior in chained transactions