Re: hint Consider using pg_file_read() - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: hint Consider using pg_file_read()
Date
Msg-id CABUevEz0i0c31evcT1hDZdzQzUOY5bCw5b1D+dAoHOu4f2ELbw@mail.gmail.com
Whole thread Raw
In response to hint Consider using pg_file_read()  (Sergei Kornilov <sk@zsrv.org>)
Responses Re: hint Consider using pg_file_read()
List pgsql-hackers
On Thu, Mar 18, 2021 at 10:58 AM Sergei Kornilov <sk@zsrv.org> wrote:
>
> Hello
> In src/backend/utils/adt/genfile.c in pg_read_file we have errhint
>
> > errhint("Consider using %s, which is part of core, instead.",
> >                                                "pg_file_read()")
>
> Shouldn't pg_read_file() be written here?

Yup, it certainly looks that way. There's a really funky combination
of names between SQL and backend there that I guess threw the original
author off.

Will fix.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: fdatasync performance problem with large number of DB files
Next
From: Masahiko Sawada
Date:
Subject: Re: New IndexAM API controlling index vacuum strategies