Re: small pg_basebackup display bug - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: small pg_basebackup display bug
Date
Msg-id CABUevEyrpT+MDo4=vY5wPXjofFAgPS8iP2ktdv_yG_HNFL_1YQ@mail.gmail.com
Whole thread Raw
In response to Re: small pg_basebackup display bug  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sun, Dec 16, 2012 at 7:20 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> On Sat, Dec 15, 2012 at 2:24 PM, Erik Rijkers <er@xs4all.nl> wrote:
>>> That would make such a truncation less frequent, and after all a truncated display is not
>>> particular useful.
>
>> Agreed - it's useful during testing, but not in a typical production
>> use. It might actually be more useful if it's truncated in in the
>> other end (keeping the last 30 instead of the first 30 chars)
>
> +1 for truncating from the left.  I think pg_upgrade already does that
> in its progress messages.

Fixed. I also fixed the output of the size parameter to be a fixed
length, so the whole row doesn't shift left and right depending on how
far long the process is.

--Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: review: pgbench - aggregation of info written into log
Next
From: Magnus Hagander
Date:
Subject: Re: default SSL compression (was: libpq compression)