Re: Prefer TG_TABLE_NAME over TG_RELNAME in tests - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Prefer TG_TABLE_NAME over TG_RELNAME in tests
Date
Msg-id CABUevExOwiBg1M0FhouXQ_Vg3S3MYX4WRnttSXY2XU=nw8z1gw@mail.gmail.com
Whole thread Raw
In response to Re: Prefer TG_TABLE_NAME over TG_RELNAME in tests  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Prefer TG_TABLE_NAME over TG_RELNAME in tests  (Andreas Karlsson <andreas@proxel.se>)
List pgsql-hackers
On Thu, Sep 24, 2020 at 5:17 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Sep 23, 2020 at 12:07:14PM +0200, Daniel Gustafsson wrote:
> > TG_RELNAME was marked deprecated in commit 3a9ae3d2068 some 14 years ago, but
> > we still use it in the triggers test suite (test added in 59b4cef1eb74a a year
> > before deprecation).  Seems about time to move over to TG_TABLE_NAME ourselves,
> > as TG_RELNAME is still covered by the test added in the deprecation commit.
>
> No objections from here to remove that from the core tests.  It is
> worth noting that Debian Code Search hints that this is used in some
> extensions:
> https://codesearch.debian.net/search?q=TG_RELNAME&literal=1
>
> These are pgformatter, bucardo, sql-ledger, ledgersmb and davical.

That's interesting, but I think irrelevant to this patch in itself of
course. But it might be worth reaching out to some of those projects
and notifying them they're using the deprecated ones..

Thus, pushed. Thanks!

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: contrib/sslinfo cleanup and OpenSSL errorhandling
Next
From: Heikki Linnakangas
Date:
Subject: Re: Split copy.c