Re: [HACKERS] Missing newlines in error messages - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [HACKERS] Missing newlines in error messages
Date
Msg-id CABUevEwE1cR+Kzh+a87mRLNq6UK8-HVun1sQWWiwizVWhn-+5Q@mail.gmail.com
Whole thread Raw
In response to [HACKERS] Missing newlines in error messages  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [HACKERS] Missing newlines in error messages
List pgsql-hackers
(oops, accidental send button press)


While poking around the pg_basebackup code, I noticed there are a lot of error messages are missing the \n at the end. Most of them are very unlikely to happen, but in general I believe all error messages we print to stderr from those binaries should have a newline at the end.

Is that wrong? :)

Second -- if we were to backpatch something like the attached patch, is that going to cause issues for translators?

On Thu, Dec 15, 2016 at 4:33 PM, Magnus Hagander <magnus@hagander.net> wrote:
While poking around the pg_basebackup code, I noticed there are a lot of error messa

--



--
Attachment

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: [HACKERS] Missing newlines in error messages
Next
From: Wesley Massuda
Date:
Subject: [HACKERS] Proposal : composite type not null constraints