Re: [HACKERS] Missing newlines in error messages - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Missing newlines in error messages
Date
Msg-id 19955.1481816335@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Missing newlines in error messages  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [HACKERS] Missing newlines in error messages  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> While poking around the pg_basebackup code, I noticed there are a lot of
> error messages are missing the \n at the end. Most of them are very
> unlikely to happen, but in general I believe all error messages we print to
> stderr from those binaries should have a newline at the end.

> Is that wrong? :)

I think you missed the fact that PQerrorMessage's result will already
end with a newline.  So most (not all) of these look OK as they stand.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Wesley Massuda
Date:
Subject: [HACKERS] Proposal : composite type not null constraints
Next
From: Dmitry Ivanov
Date:
Subject: Re: [HACKERS] Declarative partitioning - another take