Postgres Pro
Downloads
Home   >   mailing lists

Re: MERGE SQL statement for PG12 - Mailing list pgsql-hackers

From Pavan Deolasee
Subject Re: MERGE SQL statement for PG12
Date
Msg-id CABOikdPraSx-f8b+Ojp4P_HUVi8pcNVWQu2+VDoX9pnunb5j6w@mail.gmail.com
Whole thread Raw
In response to Re: MERGE SQL statement for PG12  (Jaime Casanova <jaime.casanova@2ndquadrant.com>)
Responses Re: MERGE SQL statement for PG12  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
List pgsql-hackers
Tree view


On Sun, Sep 30, 2018 at 2:55 AM Jaime Casanova <jaime.casanova@2ndquadrant.com> wrote:
On Mon, 24 Sep 2018 at 05:15, Pavan Deolasee <pavan.deolasee@gmail.com> wrote:
>
> A new version rebased against the current master is attached.
>

Hi Pavan,

A day after you posted this patch commit
29c94e03c7d05d2b29afa1de32795ce178531246 removed ExecStoreTuple.
I'm right in believe that the change in
src/backend/executor/execMerge.c should be for ExecStoreHeapTuples?

-       ExecStoreTuple(&tuple, mtstate->mt_existing, buffer, false);
+       ExecStoreHeapTuple(&tuple, mtstate->mt_existing, false);


Hi Jaime,

Thanks for keeping an eye on the patch. I've rebased the patch against the current master. A new version is attached.

Thanks,
Pavan 

--
 Pavan Deolasee                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: CVE-2017-7484-induced bugs, or, btree cmp functions are notleakproof?
Next
From: Pavel Stehule
Date:
Subject: Re: PostgreSQL vs SQL/XML Standards