Postgres Pro
Downloads
Home   >   mailing lists

Re: Bug in ALTER COLUMN SET DATA TYPE ? - Mailing list pgsql-hackers

From Pavan Deolasee
Subject Re: Bug in ALTER COLUMN SET DATA TYPE ?
Date
Msg-id CABOikdPZMxoDPYfdiojPRHBtoYkokLC1q2r4AvzGETfFdCTPXw@mail.gmail.com
Whole thread Raw
In response to Re: Bug in ALTER COLUMN SET DATA TYPE ?  (Pavan Deolasee <pavan.deolasee@gmail.com>)
Responses Re: Bug in ALTER COLUMN SET DATA TYPE ?
List pgsql-hackers
Tree view



On Fri, Nov 2, 2012 at 9:09 PM, Pavan Deolasee <pavan.deolasee@gmail.com> wrote:


I also though that for a moment, but the commit that I mentioned did not move that error message from somewhere else. I also tested by resetting to commit 1f0363001166ef6a43619846e44cfb9dbe7335ed (previous to the offending commit) and don't see any error.

But since you're seeing it, may it was taken out by some other older commit and then added back again. Will look more into it  


Here is more trace:

The error message was first added by:
commit cd902b331dc4b0c170e800441a98f9213d98b46b
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date:   Fri May 9 23:32:05 2008 +0000 

It was then removed by:
commit 61d81bd28dbec65a6b144e0cd3d0bfe25913c3ac
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date:   Mon Dec 5 15:10:18 2011 -0300

And then again added back by:
commit 09ff76fcdb275769ac4d1a45a67416735613d04b
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date:   Fri Apr 20 23:46:20 2012 -0300

So coming back to the issue, do you think it's a good idea to teach ATAddCheckConstraint() that the call is coming from a late phase of ALTER TABLE ?

Thanks,
Pavan

pgsql-hackers by date:

Previous
From: Pavan Deolasee
Date:
Subject: Re: Bug in ALTER COLUMN SET DATA TYPE ?
Next
From: Dimitri Fontaine
Date:
Subject: Re: Proposal for Allow postgresql.conf values to be changed via SQL