Re: Shmem queue is not flushed if receiver is not yet attached - Mailing list pgsql-hackers

From Pavan Deolasee
Subject Re: Shmem queue is not flushed if receiver is not yet attached
Date
Msg-id CABOikdM365tnuQPNZfH9MuE+tU4NHMcGHEiSK-oab6SgBq5XcA@mail.gmail.com
Whole thread Raw
In response to Re: Shmem queue is not flushed if receiver is not yet attached  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Shmem queue is not flushed if receiver is not yet attached  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers

Hi Robert,

On Tue, May 24, 2022 at 8:35 PM Robert Haas <robertmhaas@gmail.com> wrote:


I think that this patch is basically correct, except that it's not
correct to set mqh_counterparty_attached when receiver is still NULL.
Here's a v2 where I've attempted to correct that while preserving the
essence of your proposed fix.

This looks good to me,
 

I'm not sure that we need a shm_mq_flush(), but we definitely don't
have one currently, so I've also adjusted your patch to remove the
dead prototype.


Makes sense to me.

Thanks,
Pavan 

--
Pavan Deolasee
EnterpriseDB: https://www.enterprisedb..com

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Next
From: Pavan Deolasee
Date:
Subject: Re: Shmem queue is not flushed if receiver is not yet attached