Alvaro Herrera <alvherre@2ndquadrant.com> writes: > Tom Lane wrote: >> I think what we ought to do about this is invent additional API >> functions, say >> >> Oid CatalogTupleInsertWithInfo(Relation heapRel, HeapTuple tup, >> CatalogIndexState indstate); >> void CatalogTupleUpdateWithInfo(Relation heapRel, ItemPointer otid, >> HeapTuple tup, CatalogIndexState indstate); >> >> and use these in place of simple_heap_foo plus CatalogIndexInsert >> in the places where this optimization had been applied.
> This looks reasonable enough to me.
Done.
Thanks for taking care of this. Shame that I missed this because I'd specifically noted the special casing for large objects etc. But looks like while changing 180+ call sites, I forgot my notes.
