Postgres Pro
Downloads
Home   >   mailing lists

Re: POC: postgres_fdw insert batching - Mailing list pgsql-hackers

From Ian Lawrence Barwick
Subject Re: POC: postgres_fdw insert batching
Date
Msg-id CAB8KJ=jCUuYW8eoTP=7=CJhMCc60SS_j+pG9sEFV0deHnw-V1A@mail.gmail.com
Whole thread Raw
In response to Re: POC: postgres_fdw insert batching  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Responses Re: POC: postgres_fdw insert batching  (Ian Lawrence Barwick <barwick@gmail.com>)
Re: POC: postgres_fdw insert batching  (Ian Lawrence Barwick <barwick@gmail.com>)
List pgsql-hackers
Tree view
Hi

2021年1月21日(木) 8:00 Tomas Vondra <tomas.vondra@enterprisedb.com>:
OK, pushed after a little bit of additional polishing (mostly comments).

Thanks everyone!

There's a minor typo in the doc's version of the ExecForeignBatchInsert() declaration;
is:

    TupleTableSlot **
    ExecForeignBatchInsert(EState *estate,
                      ResultRelInfo *rinfo,
                      TupleTableSlot **slots,
                      TupleTableSlot *planSlots,
                      int *numSlots);

should be:

    TupleTableSlot **
    ExecForeignBatchInsert(EState *estate,
                      ResultRelInfo *rinfo,
                      TupleTableSlot **slots,
                      TupleTableSlot **planSlots,
                      int *numSlots);

(Trivial patch attached).


Regards

Ian Barwick

--
Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: About to add WAL write/fsync statistics to pg_stat_wal view
Next
From: Greg Nancarrow
Date:
Subject: Re: Parallel INSERT (INTO ... SELECT ...)