Postgres Pro
Downloads
Home   >   mailing lists

Re: POC: postgres_fdw insert batching - Mailing list pgsql-hackers

From Ian Lawrence Barwick
Subject Re: POC: postgres_fdw insert batching
Date
Msg-id CAB8KJ=hmC8t+yGQZiiF4fLbJTFb0_G5F94NbJqMda32M6rR9Xw@mail.gmail.com
Whole thread Raw
In response to Re: POC: postgres_fdw insert batching  (Ian Lawrence Barwick <barwick@gmail.com>)
List pgsql-hackers
Tree view


2021年1月22日(金) 14:50 Ian Lawrence Barwick <barwick@gmail.com>:
Hi

2021年1月21日(木) 8:00 Tomas Vondra <tomas.vondra@enterprisedb.com>:
OK, pushed after a little bit of additional polishing (mostly comments).

Thanks everyone!

There's a minor typo in the doc's version of the ExecForeignBatchInsert() declaration;
is:

    TupleTableSlot **
    ExecForeignBatchInsert(EState *estate,
                      ResultRelInfo *rinfo,
                      TupleTableSlot **slots,
                      TupleTableSlot *planSlots,
                      int *numSlots);

should be:

    TupleTableSlot **
    ExecForeignBatchInsert(EState *estate,
                      ResultRelInfo *rinfo,
                      TupleTableSlot **slots,
                      TupleTableSlot **planSlots,
                      int *numSlots);

(Trivial patch attached).


Regards

Ian Barwick

--


--

pgsql-hackers by date:

Previous
From: Ian Lawrence Barwick
Date:
Subject: psql tab completion for CREATE DATABASE ... LOCALE
Next
From: Ian Lawrence Barwick
Date:
Subject: Re: POC: postgres_fdw insert batching