Re: extend pgbench expressions with functions - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: extend pgbench expressions with functions
Date
Msg-id CAB7nPqTpD=PCUWojNNf5rOY+84sP6QW+=p8vGj013w1=ccAD0A@mail.gmail.com
Whole thread Raw
In response to Re: extend pgbench expressions with functions  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: extend pgbench expressions with functions
List pgsql-hackers
On Thu, Feb 11, 2016 at 12:37 AM, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
> v26 attached implements these changes.

+    /* the argument list has been built in reverse order, it is fixed here */
+    expr->u.function.args = reverse_elist(args);
Hm. I may be missing something, but why is that necessary? This is
basically doing a double-reversion to put all the arguments in the
correct order when parsing the function arguments.
-- 
Michael



pgsql-hackers by date:

Previous
From: Jacek Wielemborek
Date:
Subject: Re: Request for Code Review: BPGSQL
Next
From: Mike Rylander
Date:
Subject: Re: Fuzzy substring searching with the pg_trgm extension