Re: extend pgbench expressions with functions - Mailing list pgsql-hackers

Hello Michaël,

> +      <replaceable>parameter</>%  of the time.
> Nitpick: double space here.

Ok.

> +                   default:
> +                       return false;
>                }
> In evalFunc(), the default case in switch for the operator functions
> should never be reached. Adding for example Assert(0) is something to
> consider.

Ok for Assert + a comment.

> PGBT_NONE and PGBENCH_NONE are used nowhere. Why not removing them

Ok.

v26 attached implements these changes.

-- 
Fabien.