Re: extend pgbench expressions with functions - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: extend pgbench expressions with functions
Date
Msg-id alpine.DEB.2.10.1602101624010.14946@sto
Whole thread Raw
In response to Re: extend pgbench expressions with functions  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: extend pgbench expressions with functions
List pgsql-hackers
Hello Michaël,

> +      <replaceable>parameter</>%  of the time.
> Nitpick: double space here.

Ok.

> +                   default:
> +                       return false;
>                }
> In evalFunc(), the default case in switch for the operator functions
> should never be reached. Adding for example Assert(0) is something to
> consider.

Ok for Assert + a comment.

> PGBT_NONE and PGBENCH_NONE are used nowhere. Why not removing them

Ok.

v26 attached implements these changes.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Artur Zakirov
Date:
Subject: Re: Fuzzy substring searching with the pg_trgm extension
Next
From: David Steele
Date:
Subject: Re: Updated backup APIs for non-exclusive backups