Re: [HACKERS] [Bug fix]If recovery.conf has target_session_attrs=read-write,the standby fails to start. - Mailing list pgsql-hackers

On Sat, May 20, 2017 at 5:32 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> We'd probably be better off to implement case-insensitivity the hard way.
> There is a reason why none of our other flex scanners use this switch.

Do you think that it would be better to list the letter list for each
keyword in repl_scanner.l or have something more generic? As not that
many commands are added in the replication protocol, I would think
that this is more than enough for each command, say:
[Ss][Ll][Oo][Tt]                { return K_SLOT; }
etc.

> While I'm whining ... it looks like the other flex options selected here
> were cargo-culted in rather than being thought about.  Surely we don't
> run syncrep_scanner often enough, nor over so much data, that it's a
> good tradeoff to use the options for larger tables.

Indeed, good catch.
-- 
Michael