Re: [HACKERS] DROP SUBSCRIPTION, query cancellations and slot handling - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] DROP SUBSCRIPTION, query cancellations and slot handling
Date
Msg-id CAB7nPqTeaMD2BM84dgMYc44nHcKw9LnD9QUGOiBCdOdx2-7Xng@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] DROP SUBSCRIPTION, query cancellations and slothandling  (Petr Jelinek <petr.jelinek@2ndquadrant.com>)
Responses Re: [HACKERS] DROP SUBSCRIPTION, query cancellations and slothandling  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On Fri, Apr 21, 2017 at 11:34 AM, Petr Jelinek
<petr.jelinek@2ndquadrant.com> wrote:
> On 20/04/17 23:30, Peter Eisentraut wrote:
>> On 4/20/17 10:19, Petr Jelinek wrote:
>>> Hmm well since this only affects the synchronization of table
>>> states/names, I guess we could just simply do that before we create the
>>> slot as there is no expectancy of consistency between slot and the table
>>> list snapshot.
>>
>> I suppose that wouldn't hurt.
>>
>> Prior to the table sync patch, a missing target relation would just show
>> up as an error later on in the logs.  So having the error sooner
>> actually seems like a good change.
>>
>
> Very simple patch to make.

+1 for that.
-- 
Michael



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] some review comments on logical rep code
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] Unportable implementation of background worker start