On Thu, Apr 27, 2017 at 4:33 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> On Thu, Apr 27, 2017 at 1:58 PM, Huong Dangminh
> <huo-dangminh@ys.jp.nec.com> wrote:
>>> On Thu, Apr 27, 2017 at 11:48 AM, Masahiko Sawada <sawada.mshk@gmail.com>
>>> wrote:
>>> > Thank you for updating the patch. Also maybe we can update line in
>>> > PostgresNode.pm where hot_standby is set to on explicitly.
>>>
>>> I would refrain from doing that, having some parameters listed in the
>>> tests makes the intention behind those perl routines clear.
>
> Hmm, you've got a point. But when we changed the default values
> related to replication we dropped some explicitly settings from the
> regression test code.
Looking at the patch. This is fine:
- # Change a setting and restart
- $node->append_conf('postgresql.conf', 'hot_standby = on');
- $node->restart();
But not that: print $conf "wal_log_hints = on\n";
- print $conf "hot_standby = on\n"; print $conf "max_connections = 10\n";
This is a minor point though.
--
Michael
