Re: Should we remove "not fast" promotion at all? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Should we remove "not fast" promotion at all?
Date
Msg-id CAB7nPqT6wtNO-UOnUTWU0g93E3h6obJ-LFVEJ5yrdFgxJx3wgA@mail.gmail.com
Whole thread Raw
In response to Re: Should we remove "not fast" promotion at all?  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Tue, Aug 6, 2013 at 12:41 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> -
>> +               unlink(PROMOTE_SIGNAL_FILE);
>> Wouldn't it make sense to keep the call to stat() to check the file
>> status before unlinking it?
>
> Why do we need to check the existence of the file before removing it
> here?
Forget what I said, I had in mind that it might have been better to
put in silence errors of unlink here. This is not mandatory.
-- 
Michael



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Should we remove "not fast" promotion at all?
Next
From: Tom Lane
Date:
Subject: Re: Should we remove "not fast" promotion at all?