Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] [patch] Build pgoutput with MSVC - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] [patch] Build pgoutput with MSVC
Date
Msg-id CAB7nPqT3Rf+zhECxoTDXySNDa6ayqg-cZ=CogvaySo4rnxjKkw@mail.gmail.com
Whole thread Raw
In response to [HACKERS] [patch] Build pgoutput with MSVC  ("MauMau" <maumau307@gmail.com>)
Responses Re: [HACKERS] [patch] Build pgoutput with MSVC  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Tree view 
On Fri, May 5, 2017 at 6:10 PM, MauMau <maumau307@gmail.com> wrote:
> The pgoutput is not built with MSVC.  The attached patch fixes this.
> I confirmed that a few INSERTs were replicated correctly.
>
> Should I add this matter in the PostgreSQL 10 Open Items page?

Yes, with Peter as committer and Petr as owner.

+    my $pgoutput = $solution->AddProject(
+        'pgoutput', 'dll', '',
+        'src/backend/replication/pgoutput');
+    $pgoutput->AddReference($postgres);
Yup, that's correct.

You have forgotten to update clean.bat, which should clean up pgoutput.dll.
-- 
Michael

pgsql-hackers by date:

Previous
From: "MauMau"
Date:
Subject: [HACKERS] [patch] Build pgoutput with MSVC
Next
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] [patch] Build pgoutput with MSVC