Re: option -T in pg_basebackup doesn't work on windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: option -T in pg_basebackup doesn't work on windows
Date
Msg-id CAB7nPqSpdQdB21RujxEjDKHiyNoMM1T6Tb_TysRmEVbNexXg9w@mail.gmail.com
Whole thread Raw
In response to Re: option -T in pg_basebackup doesn't work on windows  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: option -T in pg_basebackup doesn't work on windows
Re: option -T in pg_basebackup doesn't work on windows
List pgsql-hackers
On Mon, Aug 18, 2014 at 9:37 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> It's not ready for committer if the current patch does not apply.
FWIW, the latest version sent by Amit here applies correctly:
http://www.postgresql.org/message-id/CAA4eK1+cC9RB1S9Q4+nSOkfas1YufVFGFxUHxY_6wLBQ1ReroQ@mail.gmail.com
I haven't tested it myself though.

However, independently on this patch and as pointed by MauMau, the
code that has been committed in fb05f3c is incorrect in the way it
defines the tablespace path, this:
psprintf("%s/pg_tblspc/%d", basedir, oid);
should be this:
psprintf("%s/pg_tblspc/%u", basedir, oid);
I am separating this fix (that should be backpatched to REL9_4_STABLE
as well), in the patch attached if this helps.
Regards,
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Why not ISO 8601 format for date values rendered into JSON?
Next
From: Andrew Dunstan
Date:
Subject: Re: Why not ISO 8601 format for date values rendered into JSON?