PostmasterPid not marked with PGDLLIMPORT - Mailing list pgsql-hackers

From Michael Paquier
Subject PostmasterPid not marked with PGDLLIMPORT
Date
Msg-id CAB7nPqS_=14KRCDcH6NyRsW8c58J1cwXv6QCVS7YP-6tTHQ1nA@mail.gmail.com
Whole thread Raw
Responses Re: PostmasterPid not marked with PGDLLIMPORT  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers
Hi all,

While hacking a background worker for Windows/Linux that is sending
signals to the Postmaster depending on the state of the server where
Postgres is running (particularly after a certain size threshold is
reached on the partition of PGDATA SIGINT is sent to PostmasterPid to
have it stop cleanly), I have noticed that PostmasterPid is not marked
as PGDLLIMPORT in miscadmin.h, so I cannot use the field directly in
this background worker for Windows... Bypassing this problem can be
done by parsing postmaster.pid but adding this extra logic is really
annoying as this requires a one-line change upstream...
Could it be possible to mark PostmasterPid with PGDLLIMPORT on HEAD
and back-branches?

Regards,
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "Tsunakawa, Takayuki"
Date:
Subject: Re: Question and suggestion about application binary compatibility policy
Next
From: Craig Ringer
Date:
Subject: Re: PostmasterPid not marked with PGDLLIMPORT