Re: TAP / recovery-test fs-level backups, psql enhancements etc - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: TAP / recovery-test fs-level backups, psql enhancements etc
Date
Msg-id CAB7nPqSZEyYep+xVS+NUw4t9xJ3BVwSw2f7YeWqNLD8ctDTy8Q@mail.gmail.com
Whole thread Raw
In response to Re: TAP / recovery-test fs-level backups, psql enhancements etc  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: TAP / recovery-test fs-level backups, psql enhancements etc  (Craig Ringer <craig@2ndquadrant.com>)
Re: TAP / recovery-test fs-level backups, psql enhancements etc  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Mar 2, 2016 at 2:18 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> Tom Lane wrote:
>> I wrote:
>> > Can't use string ("Test::Builder") as a HASH ref while "strict refs" in use at /usr/share/perl5/Test/Builder.pm
line1798. 
>>
>> > The referenced line number is the end of the file,
>>
>> Oh, scratch that; I was looking at the wrong file.  Actually,
>> /usr/share/perl5/Test/Builder.pm has
>>
>> sub details {
>>     my $self = shift;
>>     return @{ $self->{Test_Results} };
>> }
>>
>> and line 1798 is the "return" statement in that.  I still lack enough
>> Perl-fu to decipher this, though.
>
> I think it's complaining about being called as a class method.  Perhaps
> this would work:
>
> +       foreach my $detail (Test::More->builder->details())

Yes, that's the problem. Instead of using details(), summary() is
enough actually. And it is enough to let caller know the failure when
just one test has been found as not passing. See attached.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: TAP / recovery-test fs-level backups, psql enhancements etc
Next
From: Dilip Kumar
Date:
Subject: Re: Move PinBuffer and UnpinBuffer to atomics