Re: Why doesn't src/backend/port/win32/socket.c implement bind()? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Why doesn't src/backend/port/win32/socket.c implement bind()?
Date
Msg-id CAB7nPqSY2q6t1S-zQnjogDCTox2sv14w2jPdthYs3CUZ8UK91Q@mail.gmail.com
Whole thread Raw
In response to Re: Why doesn't src/backend/port/win32/socket.c implement bind()?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Apr 15, 2016 at 12:13 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Michael Paquier <michael.paquier@gmail.com> writes:
>> On Thu, Apr 14, 2016 at 9:38 AM, Michael Paquier
>> <michael.paquier@gmail.com> wrote:
>>> IO::Socket::INET is another option, but I am not seeing it in perl <
>>> 5.12, and that's not part of ActivePerl, which makes life harder on
>>> Windows. Socket is available on both. Does that address your concerns?
>
>> And this gives the patch attached, just took the time to hack it.
>
> I think this is a good idea, but (1) I'm inclined not to restrict it to
> Windows, and (2) I think we should hold off applying it until we've seen
> a failure or two more, and can confirm whether d1b7d4877 does anything
> useful for the error messages.

Both arguments are fine for me.
-- 
Michael



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Obsolete comment within fmgr.c
Next
From: Peter Geoghegan
Date:
Subject: Re: Draft release notes for next week's releases